Allow services to avoid setting project ID #346

ajkannan · 2015-11-10T21:02:34Z

This PR makes setting the project ID optional for service libraries that don't require a project ID (such as Resource Manager).

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

+   *
+   * @return true if a project ID is required to use the service, false if not.
+   */
+  public boolean projectIdRequired() {


ajkannan · 2015-11-10T23:04:24Z

@aozarov updated to make method protected

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

-    projectId = checkNotNull(builder.projectId != null ? builder.projectId : defaultProject());
+    projectId = builder.projectId != null ? builder.projectId : defaultProject();
+    if (projectIdRequired()) {
+      checkNotNull(projectId);


…sage if project could not be determined and is required

Allow services to avoid setting project ID

🤖 I have created a release *beep* *boop* --- ## [1.3.1](googleapis/java-accesscontextmanager@v1.3.0...v1.3.1) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#346](googleapis/java-accesscontextmanager#346)) ([adbd804](googleapis/java-accesscontextmanager@adbd804)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…2.1 (googleapis#346) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `16.2.0` -> `16.2.1` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).

* chore: relocate owl bot post processor * chore: relocate owl bot post processor * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…14.7 (#346) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.6` -> `2.14.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/compatibility-slim/2.14.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.14.7/confidence-slim/2.14.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.14.7`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2147-httpsgithubcomgoogleapisjava-bigquerycomparev2146v2147-2022-08-23) ##### Bug Fixes - table-not-found issue with executeSelect while running long queries ([#2222](https://togithub.com/googleapis/java-bigquery/issues/2222)) ([4876569](https://togithub.com/googleapis/java-bigquery/commit/487656973fe3e06d838c1b495ac024ab2c6810f6)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights).

🤖 I have created a release *beep* *boop* --- ## [2.3.3](googleapis/java-workflow-executions@v2.3.2...v2.3.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#345](googleapis/java-workflow-executions#345)) ([2cfa42a](googleapis/java-workflow-executions@2cfa42a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Allow services to avoid setting project ID

ad12f41

ajkannan added the api: core label Nov 10, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 10, 2015

aozarov reviewed Nov 10, 2015
View reviewed changes

gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

*

* @return true if a project ID is required to use the service, false if not.

*/

public boolean projectIdRequired() {

This comment was marked as spam.

Sign in to view

aozarov reviewed Nov 10, 2015
View reviewed changes

Make projectIdRequired() method protected. Also supply nice error mes…

6c40825

…sage if project could not be determined and is required

ajkannan force-pushed the project-id-optional branch from 4bbc9e8 to 6c40825 Compare November 10, 2015 23:39

aozarov added a commit that referenced this pull request Nov 10, 2015

Merge pull request #346 from ajkannan/project-id-optional

ed1d437

Allow services to avoid setting project ID

aozarov merged commit ed1d437 into googleapis:master Nov 10, 2015

ajkannan deleted the project-id-optional branch November 10, 2015 23:52

This was referenced Aug 24, 2022

chore: release monorepo_script_output #8199

Closed

chore: release main #8222

Closed

release-please bot mentioned this pull request Sep 23, 2022

chore: release main #8444

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow services to avoid setting project ID #346

Allow services to avoid setting project ID #346

ajkannan commented Nov 10, 2015

This comment was marked as spam.

ajkannan commented Nov 10, 2015

This comment was marked as spam.

This comment was marked as spam.

Allow services to avoid setting project ID #346

Allow services to avoid setting project ID #346

Conversation

ajkannan commented Nov 10, 2015

This comment was marked as spam.

ajkannan commented Nov 10, 2015

This comment was marked as spam.

This comment was marked as spam.